test: use Vec::with_capacity avoid realloc mem #101
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelabro
requested changes
Jan 23, 2025
| @@ -1081,7 +1081,7 @@ mod test { | |||
| // Helper function to generate a vector of bits for testing purposes | |||
| fn generate_be_bits(x: &Felt) -> Vec<bool> { | |||
| // Initialize an empty vector to store the expected bits | |||
| let mut bits = Vec::new(); | |||
| let mut bits = Vec::with_capacity(x.0.representative().limbs.len() * 8 * 8); | |||
There was a problem hiding this comment.
The call to representative is not free at all.
Now there are two of those.
If you want to do this you should
let representative = x.0.representative();
let mut bits = Vec::with_capacity(limbs.len() * 8 * 8);
for limb in representative.limbs {
There was a problem hiding this comment.
This is not what you did.
nkysg
force-pushed
the
test_use_Vec_with_capacity
branch
from
af7a414 to
a7774fb
Compare
nkysg
force-pushed
the
test_use_Vec_with_capacity
branch
from
a7774fb to
7254cbf
Compare
|
@nkysg run the tests locally before you push |
tdelabro
requested changes
Mar 22, 2025
|
|
||
| // Iterate over each limb in the representative of x | ||
| for limb in x.0.representative().limbs { | ||
| for limb in bits.limbs { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
test: use Vec::with_capacity avoid realloc mem
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
Other information