-
Notifications
You must be signed in to change notification settings - Fork 126
Merge integration tests #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge integration tests #2131
Conversation
Signed-off-by: Abhishek <[email protected]>
Signed-off-by: Abhishek <[email protected]>
@ChrisJBurns I just realized that, with the existing folder structure, |
I'm not entirely sure about that - I didn’t intend to make |
@dmartinol I don't think it was intended, I'm happy to have several tasks for the different tests if you feel it's useful. unit / integration / e2e / all. It's tricky because the root |
let's resolve this once we split the operator in its own repo: there we can move ITs in dedicated folder and remove ambiguities. I would approve this as is once @abhiii71 removes the |
Signed-off-by: Abhishek <[email protected]>
Removed the redundant operator-e2e-test-ginkgo task to avoid ambiguity with existing test tasks, as suggested by @dmartinol. Is there anything else that needs to be addressed or anything left? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2131 +/- ##
==========================================
- Coverage 48.89% 48.84% -0.05%
==========================================
Files 242 242
Lines 30714 30714
==========================================
- Hits 15017 15003 -14
- Misses 14572 14590 +18
+ Partials 1125 1121 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
some CI tests to fix, like:
an you hanlde this, @abhiii71 ? |
@dmartinol, Got it! I can take a look at the CI failures related to the CRD files. I’ll investigate why the path is failing and propose a fix. Do you want me to create a separate PR for this fix once ready? |
This PR reorganizes and merges the existing operator integration and e2e tests into a single consistent location under cmd/thv-operator/test-integration/ for better maintainability. Specifically:
Moved MCPRegistry tests to cmd/thv-operator/test-integration/mcp-registry
Moved MCPServer tests to cmd/thv-operator/test-integration/mcp-server
Updated Taskfile and CI workflows to run all operator e2e tests in a single task
Fixed CRD paths for proper test environment setup
These changes align with the issue #2125
regarding consolidating operator integration tests.
Linked Issue:
#2125