Skip to content

Conversation

abhiii71
Copy link
Contributor

@abhiii71 abhiii71 commented Oct 10, 2025

Fix #2131

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.85%. Comparing base (866b10d) to head (63a040a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
+ Coverage   48.82%   48.85%   +0.03%     
==========================================
  Files         242      242              
  Lines       30714    30714              
==========================================
+ Hits        14996    15006      +10     
+ Misses      14596    14580      -16     
- Partials     1122     1128       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abhiii71
Copy link
Contributor Author

abhiii71 commented Oct 10, 2025

@ChrisJBurns Should i change .github/workflows/operator-ci.yml and cmd/thv-operator/Taskfile.yml as well ?

@dmartinol
Copy link
Collaborator

@ChrisJBurns Should i change .github/workflows/operator-ci.yml and cmd/thv-operator/Taskfile.yml as well ?

I think that Run Ginkgo tests and the operator-tests-integration in the CI workflow are now equivalent, I would remove the Install Ginkgo CLI and Run Ginkgo tests

@dmartinol dmartinol self-requested a review October 10, 2025 07:26
dmartinol
dmartinol previously approved these changes Oct 10, 2025
@dmartinol dmartinol self-requested a review October 10, 2025 08:51
Copy link
Collaborator

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you again!

@dmartinol dmartinol merged commit 0fe8402 into stacklok:main Oct 10, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants