Skip to content

arrow: add mimalloc variant #5632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathomp4 wants to merge 1 commit into
base: develop
Choose a base branch
from
+12 −1
Open

arrow: add mimalloc variant #5632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion repos/spack_repo/builtin/packages/arrow/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,11 @@ class Arrow(CMakePackage, CudaPackage):
variant("ipc", default=True, description="Build the Arrow IPC extensions")
variant("jemalloc", default=False, description="Build the Arrow jemalloc-based allocator")
variant("lz4", default=False, description="Build support for lz4 compression")
variant(
"mimalloc",
default=True,
description="Build the Arrow mimalloc-based allocator",
)
variant("orc", default=False, description="Build integration with Apache ORC")
variant("parquet", default=False, description="Build Parquet interface")
variant("python", default=False, description="Build Python interface")
Expand Down Expand Up @@ -174,8 +179,14 @@ def cmake_args(self):
args.append(self.define("ARROW_USE_SSE", "ON"))

# https://github.com/apache/arrow/issues/47790
if self.spec.satisfies("%oneapi@2025:"):
# mimalloc is always vendored (no system lookup); Arrow downloads its source
# via FetchContent at build time, which fails on air-gapped compute nodes.
# The ~mimalloc variant allows disabling it for such environments.
# Note: oneapi@2025: also has a compiler bug requiring MIMALLOC=OFF regardless.

@thomas-bouvier thomas-bouvier Jul 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a link to the relevant issue or PR be added to this comment?

@mathomp4 mathomp4 Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be one line above (was already there):

apache/arrow#47790

if self.spec.satisfies("%oneapi@2025:") or self.spec.satisfies("~mimalloc"):
args.append(self.define("ARROW_MIMALLOC", "OFF"))
else:
args.append(self.define_from_variant("ARROW_MIMALLOC", "mimalloc"))

args.append(self.define_from_variant("ARROW_COMPUTE", "compute"))
args.append(self.define_from_variant("ARROW_CSV", "csv"))
Expand Down
Loading