Skip to content

arrow: add mimalloc variant#5632

Open
mathomp4 wants to merge 1 commit into
spack:developfrom
mathomp4:arrow-mimalloc
Open

arrow: add mimalloc variant#5632
mathomp4 wants to merge 1 commit into
spack:developfrom
mathomp4:arrow-mimalloc

Conversation

@mathomp4

Copy link
Copy Markdown
Contributor

When building on an air-gapped system, it turns out arrow does a FetchContent at CMake time.

This PR adds the ability to do ~mimalloc to bypass mimalloc.

@mathomp4
mathomp4 requested a review from adamjstewart July 17, 2026 13:10
@spackbot-triage spackbot-triage Bot added update-package Modifications to packages in the repository new-variant Modifications to packages' `variant()` directives labels Jul 17, 2026
@mathomp4
mathomp4 requested a review from thomas-bouvier July 17, 2026 13:11
# mimalloc is always vendored (no system lookup); Arrow downloads its source
# via FetchContent at build time, which fails on air-gapped compute nodes.
# The ~mimalloc variant allows disabling it for such environments.
# Note: oneapi@2025: also has a compiler bug requiring MIMALLOC=OFF regardless.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a link to the relevant issue or PR be added to this comment?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be one line above (was already there):

apache/arrow#47790

@thomas-bouvier thomas-bouvier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-variant Modifications to packages' `variant()` directives update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants