This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
[SG-37398] - Migrate graphqlbackend.RepositoryResolver to use sourcegraph/log #38902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
running a main dry run: https://buildkite.com/sourcegraph/sourcegraph/builds/161193 |
bobheadxi
approved these changes
Jul 16, 2022
|
the main-dry-run passed |
bobheadxi
reviewed
Jul 16, 2022
| @@ -584,6 +584,7 @@ func (r *UserResolver) PublicRepositories(ctx context.Context) ([]*RepositoryRes | |||
| var out []*RepositoryResolver | |||
| for _, repo := range repos { | |||
| out = append(out, &RepositoryResolver{ | |||
| logger: r.logger, | |||
There was a problem hiding this comment.
@gitstart-sourcegraph wait, how is r.logger initialized? I see no code indicating that UserResolver is ever created with a logger
There was a problem hiding this comment.
vovakulikov
pushed a commit
that referenced
this pull request
Jul 20, 2022
…raph/log (#38902) Co-authored-by: gitstart-sourcegraph <[email protected]> Co-authored-by: Robert Lin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a logger to schemaResolver, and initialize it with log.Scoped (or logtest where appropriate) wherever schemaResolver is created (unless an existing logger is easily available, in which case that should be used)
Add a logger to RepositoryResolver, and let it be injected from NewRepositoryResolver. Use log.Scoped (or logtest where appropriate) to provide the logger at all usages of NewRepositoryResolver
3 log15 usages inside cmd/frontend/graphqlbackend/repository.go are replaced with calls to the appropriate logger
Test plan
Refs