Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

logging(gitstart): migrate graphqlbackend.RepositoryResolver to use sourcegraph/log #37398

Closed
bobheadxi opened this issue Jun 18, 2022 · 1 comment · Fixed by #38902
Closed
Assignees
Labels
estimate/1d gitstart Contract partner

Comments

@bobheadxi
Copy link
Member

bobheadxi commented Jun 18, 2022

Problem statement

https://github.com/sourcegraph/sourcegraph/issues/36382

Success criteria

  • Add a logger to schemaResolver, and initialize it with log.Scoped (or logtest where appropriate) wherever schemaResolver is created (unless an existing logger is easily available, in which case that should be used)
  • Add a logger to RepositoryResolver, and let it be injected from NewRepositoryResolver. Use log.Scoped (or logtest where appropriate) to provide the logger at all usages of NewRepositoryResolver
  • 3 log15 usages inside cmd/frontend/graphqlbackend/repository.go are replaced with calls to the appropriate logger

Time estimate

  • Pull requests with ~450 lines changed should take 24 hours at maximum. Ping the reviewer in the spec pull request if time-consuming changes are required.
@gitstart-app
Copy link
Contributor

gitstart-app bot commented Jun 18, 2022

Here is the GitStart Ticket for this issue: https://app.gitstart.com/clients/sourcegraph/tickets/SG-37398

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.