Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

logging(gitstart) tracking issue: migrate graphqlbackend to use sourcegraph/log #36382

Closed
3 of 4 tasks
bobheadxi opened this issue Jun 1, 2022 · 1 comment
Closed
3 of 4 tasks
Assignees
Labels
gitstart Contract partner tracking

Comments

@bobheadxi
Copy link
Member

bobheadxi commented Jun 1, 2022

Problem statement

The graphqlbackend layer in Sourcegraph's frontend service has a lot of log15 usage. As a core entrypoint to many parts of Sourcegraph, having this layer migrated could help speed adoption of the new logging library.

Success criteria

All 85 usages of log15 in cmd/frontend/graphqlbackend are replaced with usages of appropriately scoped loggers.

https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24+file:%5Ecmd/frontend/graphqlbackend+log15&patternType=literal

Implementation details

Most usages here fall in one of two places:

  1. a resolver struct function
  2. a helper function

In case 1, the resolver struct should hold a reference to a log.Logger. In case 2, the helper should accept a logger parameter.

Tracked issues

@gitstart-sourcegraph: 1.50d

Completed: 1.50d

@gitstart-app
Copy link
Contributor

gitstart-app bot commented Jun 1, 2022

Here is the GitStart Ticket for this issue: https://app.gitstart.com/clients/sourcegraph/tickets/SG-36382

@bobheadxi bobheadxi closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2022
@bobheadxi bobheadxi removed gitstart Contract partner team/devx labels Jun 17, 2022
@bobheadxi bobheadxi reopened this Jun 17, 2022
@bobheadxi bobheadxi changed the title logging(gitstart): migrate graphqlbackend to use lib/log logging(gitstart): migrate graphqlbackend to use sourcegraph/log Jun 17, 2022
@bobheadxi bobheadxi changed the title logging(gitstart): migrate graphqlbackend to use sourcegraph/log logging(gitstart) tracking issue: migrate graphqlbackend to use sourcegraph/log Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gitstart Contract partner tracking
Projects
None yet
Development

No branches or pull requests

3 participants