fix(message-handler): cleanup stale pendingReplies to prevent memory leak#60
Open
kumudasrip wants to merge 5 commits into
Open
fix(message-handler): cleanup stale pendingReplies to prevent memory leak#60kumudasrip wants to merge 5 commits into
kumudasrip wants to merge 5 commits into
Conversation
Author
|
Hello @snackoverflowasad @shouri123 |
Author
|
I pushed a small follow-up fix after the CI failure.
The CI failure looks related to the repo’s formatting/build checks rather than the new |
Author
|
I fixed the follow-up CI failure by removing the duplicate service test file and consolidating the new cleanup tests into the existing tests/messageHandlerService.test.ts suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
lastActivitytracking for each pending reply entry insrc/services/messageHandler.service.tspendingRepliesentries after the configured inactivity TTLCHAT_BUDDY_PENDING_REPLY_TTL_HOURSCHAT_BUDDY_PENDING_REPLY_CLEANUP_INTERVAL_MSsrc/cli/run.tsRelated Issue Number
Type of Change
How Was This Tested
src/services/messageHandler.service.tsandsrc/cli/run.tsChecklist
npm run build)npm test)