fix: add TTL cleanup for pendingReplies memory leak#49
Closed
kumudasrip wants to merge 5 commits into
Closed
Conversation
Author
|
Hello @snackoverflowasad , This PR fixes issue #45 |
Owner
|
Hey @kumudasrip please check for ci builds test |
…into fix/memoryleak
Author
|
I have updated the changes for ci build tests failure |
shouri123
approved these changes
Jun 7, 2026
Collaborator
Sime checks are not running |
Collaborator
|
@kumudasrip please check again the prs it not running the checks are not running |
Author
Resolving them, I will open a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Implemented a TTL-based cleanup mechanism for the
pendingRepliesmap to prevent unbounded memory growth in long-running deployments.Changes made:
Added
lastActivityAtMstracking for each pending reply entry.Implemented automatic cleanup of stale inactive entries.
Added configurable environment variables:
CHAT_BUDDY_PENDING_REPLY_TTL_HOURSCHAT_BUDDY_PENDING_REPLY_CLEANUP_INTERVAL_MSAdded interval lifecycle management to avoid unnecessary timers.
Ensured cleanup timers and pending timeouts are gracefully terminated during bot shutdown.
Added validation and clamping for TTL and cleanup interval values.
Updated:
.env.exampleREADME.mdCONTRIBUTING.mdCHANGELOG.mdThis prevents inactive users from remaining indefinitely in memory and stabilizes memory usage for long-running bot instances.
Related Issue Number
Closes #45
Type of Change
How Was This Tested?
Manual Testing
Started the bot using:
Verified:
Tested different environment variable values:
Build Verification
Additional Validation
Checklist
npm run build).npm test).