Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp: fix retransmit exponential backoff, align to rfc6298. #1023

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Dec 27, 2024

Align RTT estimation and RTO calculation to RFC 6298.

In particular, this fixes exponential backoff in retransmissions, because
the RTO is supposed to be stored in a persistent variable so we can double it on
retransmission and have it "stick", while we were storing it in the timer which would
get cleared every time we exited retransmit state.

closes #1020

  • tcp: emsure line numbers in tests point to the actual failure.
  • tcp: fix retransmit exponential backoff, align to rfc6298.
  • tcp: add retransmission exponential backoff test.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 98.24561% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.88%. Comparing base (37a6e1c) to head (e826989).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/socket/tcp.rs 98.24% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
+ Coverage   80.83%   80.88%   +0.05%     
==========================================
  Files          81       81              
  Lines       28419    28447      +28     
==========================================
+ Hits        22973    23010      +37     
+ Misses       5446     5437       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dirbaio Dirbaio added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 104898b Dec 27, 2024
12 checks passed
@Dirbaio Dirbaio deleted the rfc-rtte branch December 27, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants