Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, after a TCP retransmit, the socket timer was set to idle, which means that no actions except for keep-alive are required.
This is incorrect in the case where another TCP retransmission will be required.
This PR adds a test and fixes the problem.
And just to make sure I didn't miss anything - what if
set_for_retransmit
sets a timeout larger than the keep alive?I assume that's OK because the socket won't close with unacknowledged data?