Skip to content

feat: minor version strategy rules #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 22, 2025
Merged

feat: minor version strategy rules #1410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c830a7
feat: minor version strategy rules
0marperez Sep 18, 2025
e8b465d
fix workflow
0marperez Sep 18, 2025
9eb335a
test simplification
0marperez Sep 19, 2025
c5b0712
use prod action
0marperez Sep 19, 2025
31d3acc
Update libs.versions.toml
0marperez Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/minor-version-bump.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: Minor version bump check
on:
pull_request:

jobs:
minor-version-bump-check:
permissions: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to specify this? Isn't the default "no permissions"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to specify it. The default is likely read and write, I ran into issues with this recently: https://github.com/smithy-lang/smithy-kotlin/security/code-scanning/93

We also do the same in other workflows for the same reason:
https://github.com/aws/aws-sdk-kotlin/blob/8716c234c59185fd09d819c65189ab6d4ede071d/.github/workflows/continuous-integration.yml#L7

runs-on: ubuntu-latest
steps:
- name: Minor version bump check
uses: awslabs/aws-kotlin-repo-tools/.github/actions/minor-version-bump@main
2 changes: 2 additions & 0 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/
import aws.sdk.kotlin.gradle.dsl.configureJReleaser
import aws.sdk.kotlin.gradle.dsl.configureLinting
import aws.sdk.kotlin.gradle.dsl.configureMinorVersionStrategyRules
import aws.sdk.kotlin.gradle.util.typedProp
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

Expand Down Expand Up @@ -109,6 +110,7 @@ val lintPaths = listOf(
)

configureLinting(lintPaths)
configureMinorVersionStrategyRules(lintPaths)

// Binary compatibility
apiValidation {
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
kotlin-version = "2.2.0"
dokka-version = "2.0.0"

aws-kotlin-repo-tools-version = "0.4.50"
aws-kotlin-repo-tools-version = "0.4.54"

# libs
coroutines-version = "1.10.2"
Expand Down
Loading