feat: minor version strategy rules #1410
Conversation
0marperez
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| jobs: | ||
| minor-version-bump-check: | ||
| permissions: {} |
There was a problem hiding this comment.
Do you need to specify this? Isn't the default "no permissions"?
There was a problem hiding this comment.
It's best to specify it. The default is likely read and write, I ran into issues with this recently: https://github.com/smithy-lang/smithy-kotlin/security/code-scanning/93
We also do the same in other workflows for the same reason:
https://github.com/aws/aws-sdk-kotlin/blob/8716c234c59185fd09d819c65189ab6d4ede071d/.github/workflows/continuous-integration.yml#L7
| steps: | ||
| - name: Check branch name | ||
| run: | | ||
| # Only continue on branches starting with vX.X (e.g. v1.2, v1.2.3, v1.2-main) | ||
| if [[ ! "$GITHUB_HEAD_REF" =~ ^v\.[0-9]+\.[0-9]+.*$ ]]; then | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
This whole step can be removed by using an if: configuration and checking github.ref
There was a problem hiding this comment.
As far as I know we can't use regex in conditionals but I'll give it a try.
There was a problem hiding this comment.
If it's not simple to implement don't spend too much time getting it to work. It just looked like this could be replaced with an if on the step
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Affected ArtifactsChanged in size
|
Issue #
N/A
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.