Repository navigation
docs: document mzLib 1.0.595's result changes; PRIDE calls add no timeout of their own - #35
Merged
Merged
Conversation
…no timeout of its own Ports pyMzLib #87 (38948d8). The pyMzLib 0.5.0 bridge carried mzLib 1.0.595 with more changed results than NEWS named. Each is now in NEWS's mzLib 1.0.595 section, in R terms, and on the help pages (specs re-synced from bridge f85fef7): ProForma input refusals (#1462), SUMO and TMTpro names (#1432, #1419), Lactylation's mass (#1417), entrapment flags and entrapment_fraction (#1371), FlashLFQ normalization and gapped designs (#1422, #1424), |P proteases at sequence ends (#1320), stats_fit below 3 features (#1398), PRIDE retries, resumable .partial pairs and the missing download checks (#1412, #1427, #1449). The conversions, the stats_fit prior and the entrapment_fraction column were re-checked from R against the 0.5.0 bridge (d10017ce). - pride_list_files(), pride_list_ftp_files() and pride_search(): timeout defaults to NULL, not 300. mzLib bounds each request (#1412), so a hanging outage is reported as mzlib_service_unavailable, not mzlib_timeout. An explicit timeout still applies. - ?stats_fit: prior$scale is NA with fewer than 3 features, where mzLib fits no prior; bridges before pyMzLib 0.5.1 report the first feature's own variance there. Contrasts exist in mzLib (#1452) but are not exposed yet. - The PRIDE article and ?mzlib_error say mzLib already retried, so a retry waits minutes; the article covers .partial resumes and checking large files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nbjsh1WCYFwbbG5CPbRygW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports pyMzLib #87 to mzLibR. It documents every result change that mzLib 1.0.595 brought with the 0.5.0 bridge, and it drops the package's own PRIDE timeout.
What changes
pride_list_files(),pride_list_ftp_files()andpride_search()default totimeout = NULL, not 300. mzLib already bounds each request: three retries after 5, 20 and 60 s, with each attempt up to 100 s (#1412). A 300 s limit of the package's own therefore turned a hanging PRIDE outage into a timeout instead ofmzlib_service_unavailable. Passtimeout = 300for the old limit.UNIMOD:2114(#1417);entrapment_fraction(#1371);|Pproteases at sequence ends (#1320);stats_fit()below 3 features (#1398);.partialresumption (#1412);pride_download()(#1427, #1449);?stats_fitsaysprior$scaleisNAwith fewer than 3 features, and that bridges before pyMzLib 0.5.1 report the first feature's variance there. Today's 0.5.0 bridge does that: a 2-feature fit shows 0.0251.?pride_downloadcovers the resumable.partialpairs.?mzlib_errornames the two EBI failures that still arrive as a bridge error after mzLib's retries: an empty FTP listing and an EBI FTP 403.stats_fit()does not expose them yet.f85fef7, 49 help pages rebuilt, anddocs/name-parity.mdregenerated (header only).Tests
The new "PRIDE's metadata calls add no timeout of their own" test fails on the old code, where the stand-in runner sees 300 for all three functions. A second test checks that an explicit timeout still reaches the bridge.
Verified locally with R 4.6.1:
sync-specs,stage-replay,render-cite,docs-lint,build-manandname-parityare all current;R CMD check --as-cran --no-manual --ignore-vignettes: OK. Pandoc is not installed locally, so CI builds the vignettes.One known gap, recorded upstream as PRIDE-B3: until mzLib marks its exhausted transient failures, an empty FTP listing or an EBI FTP 403 arrives as
mzlib_bridge_error. The live canaries skip only onmzlib_service_unavailable, so during such an outage they fail instead of skipping.🤖 Generated with Claude Code