-
Notifications
You must be signed in to change notification settings - Fork 684
[ENH] tests for TiDE
Model
#1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
### Description This PR implements the basic skeleton of D1 and D2 layer for v2. See sktime#1736 for discussion and design.
This PR solves the bug in `data_module` where the `static_categorical_features` and `static_continuous_features` were not correctly calculated in `__getitem__` of nested class
…time#1827) ### Description This PR fixes [1823](sktime#1823)
…1832) This PR makes the `data_modulel` dataclass-like See discussion in sktime#1829
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
=======================================
Coverage ? 85.01%
=======================================
Files ? 62
Lines ? 6166
Branches ? 0
=======================================
Hits ? 5242
Misses ? 924
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also tests for TFT in here - does this PR accidentally stack on something else as well?
I had pulled the latest changes. Fixed it now with a rebase. |
Not sure what happened, but just speaking from experience, I would suggest to prefer |
Thanks for the heads-up. For now, the commit history seems fine, if any issues do come up, then the issue might point to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding your questions what to do next:
- I would add the metadata class next, simply follow pattern in
DeepARMetadata
, and see what happens if it gets tested - potentially, there is a clash between the integrations, in this case we need to resolve by adding further variable parts
- @phoeenniixx is not stacking on 1843 for v1, so you can add a metadata class and you do not need to stack on each other (he is diverging)
Yes, this change has been pushed, for now I have returned only one-two set of arguments in
I ran the EDIT: these were small fixes, everything seems to be working fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will merge #1780 since two Pr are now stacking or forking. We can add tests for more models later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged the test PR to reduce the stack.
Question: you mentioned on #1780 that _integration
would pose a problem due to the cell_type
arg, but this PR did pass even before I moved it to kwargs.
Can you explain that? Why was it not a problem?
I had already made the necessary change in this PR, before you added them to the kwargs in #1780. |
Ah, I did not see that - what did you do, if I may ask? (I could dig into the commits, but I would appreciate if you summarize, that might be quicker) Did we make identical changes, or did you do sth else? In any case, that is what I meant with "identifying variable parts" - for instance, by considering a second example, we now learnt that even the presence of |
I removed you can view the changes in the commit. |
I also added them to the I am guessing you did not do that? It is not good style to change the logic in another part of the code base (at least without making this clear in the PR description) just to make your changes work. |
Will keep this in mind next time. Thanks for pointing it out. |
Description
This PR fixes #1807 and stacks upon PR #1780. Builds upon the PR #1814 (closed due to complex commit history).
Checklist
pre-commit install
.To run hooks independent of commit, execute
pre-commit run --all-files