[ENH] tests for `TiDE` Model #1843

PranavBhatP · 2025-05-22T06:19:13Z

Description

This PR fixes #1807 and stacks upon PR #1780. Builds upon the PR #1814 (closed due to complex commit history).

Checklist

Linked issues (if existing)
Amended changelog for large changes (and added myself there as contributor)
Added/modified tests
Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
To run hooks independent of commit, execute pre-commit run --all-files

### Description This PR implements the basic skeleton of D1 and D2 layer for v2. See sktime#1736 for discussion and design.

This PR solves the bug in `data_module` where the `static_categorical_features` and `static_continuous_features` were not correctly calculated in `__getitem__` of nested class

…time#1827) ### Description This PR fixes [1823](sktime#1823)

…1832) This PR makes the `data_modulel` dataclass-like See discussion in sktime#1829

codecov · 2025-05-22T13:11:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@aa3bc9d). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1843   +/-   ##
=======================================
  Coverage        ?   85.01%           
=======================================
  Files           ?       62           
  Lines           ?     6166           
  Branches        ?        0           
=======================================
  Hits            ?     5242           
  Misses          ?      924           
  Partials        ?        0

Flag	Coverage Δ
cpu	`85.01% <100.00%> (?)`
pytest	`85.01% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fkiraly

There are also tests for TFT in here - does this PR accidentally stack on something else as well?

PranavBhatP · 2025-05-23T07:17:32Z

There are also tests for TFT in here - does this PR accidentally stack on something else as well?

I had pulled the latest changes. Fixed it now with a rebase.

phoeenniixx · 2025-05-23T20:19:28Z

Fixed it now with a rebase.

Not sure what happened, but just speaking from experience, I would suggest to prefer merge over rebase. Sometimes it creates more hassle than it’s worth.
See this comment: sktime/sktime#7334 (comment)

PranavBhatP · 2025-05-25T16:34:33Z

I would suggest to prefer merge over rebase. Sometimes it creates more hassle than it’s worth.

Thanks for the heads-up. For now, the commit history seems fine, if any issues do come up, then the issue might point to this.

fkiraly

Regarding your questions what to do next:

I would add the metadata class next, simply follow pattern in DeepARMetadata, and see what happens if it gets tested
potentially, there is a clash between the integrations, in this case we need to resolve by adding further variable parts
@phoeenniixx is not stacking on 1843 for v1, so you can add a metadata class and you do not need to stack on each other (he is diverging)

PranavBhatP · 2025-05-27T13:17:30Z

@fkiraly

I would add the metadata class next, simply follow pattern in DeepARMetadata, and see what happens if it gets tested

Yes, this change has been pushed, for now I have returned only one-two set of arguments in get_test_train_params(). We can extend the number of test kwargs later.

potentially, there is a clash between the integrations, in this case we need to resolve by adding further variable parts

I ran the test_all_estimators.py file on TiDEModel, and there are errors due to model-specific implementations in TiDE. Will try figuring out changes to make this work. ~~Until then this PR is blocked~~. You can view the errors once the CI runs completes.

EDIT: these were small fixes, everything seems to be working fine now.

fkiraly

ok, I will merge #1780 since two Pr are now stacking or forking. We can add tests for more models later.

fkiraly

I merged the test PR to reduce the stack.

Question: you mentioned on #1780 that _integration would pose a problem due to the cell_type arg, but this PR did pass even before I moved it to kwargs.

Can you explain that? Why was it not a problem?

PranavBhatP · 2025-05-28T08:28:11Z

I had already made the necessary change in this PR, before you added them to the kwargs in #1780.

fkiraly · 2025-05-28T09:07:00Z

I had already made the necessary change in this PR

Ah, I did not see that - what did you do, if I may ask? (I could dig into the commits, but I would appreciate if you summarize, that might be quicker)

Did we make identical changes, or did you do sth else?

In any case, that is what I meant with "identifying variable parts" - for instance, by considering a second example, we now learnt that even the presence of cell_type is variable.

PranavBhatP · 2025-05-28T11:44:52Z

what did you do, if I may ask? (I could dig into the commits, but I would appreciate if you summarize, that might be quicker)

I removed cell_type and n_plotting_samples from the from_dataset() method inside test_all_estimators.py. I'm assuming you have made the same changes, hence the absence of a merge conflict?

you can view the changes in the commit.

fkiraly · 2025-05-29T06:09:21Z

I removed cell_type and n_plotting_samples from the from_dataset() method inside test_all_estimators.py. I'm assuming you have made the same changes, hence the absence of a merge conflict?

I also added them to the get_test_train_params, so it does not change internal logic, only structure - as a pure refactor.

I am guessing you did not do that? It is not good style to change the logic in another part of the code base (at least without making this clear in the PR description) just to make your changes work.

PranavBhatP · 2025-05-29T06:12:06Z

I am guessing you did not do that? It is not good style to change the logic in another part of the code base (at least without making this clear in the PR description) just to make your changes work.

Will keep this in mind next time. Thanks for pointing it out.

fkiraly and others added 30 commits February 22, 2025 23:18

test suite

b3644a6

Merge branch 'main' into test-suite

a1d64c6

skeleton

4b2486e

skeleton

02b0ce6

Update test_all_estimators.py

41cbf66

Update _base_object.py

cef62d3

Update _lookup.py

bc2e93b

Update _lookup.py

eee1c86

base metadatda

164fe0d

registry

20e88d0

fix private name

318c1fb

Update _base_object.py

012ab3d

test failure

86365a0

Update test_all_estimators.py

f6dee46

Update test_all_estimators.py

9b0e4ec

Update test_all_estimators.py

7de5285

test folders

57dfe3a

Update test.yml

c9f12db

test integration

fa8144e

fixes

232a510

Update _conftest.py

1c8d4b5

try scenarios

f632e32

Merge branch 'main' into test-suite

ef37f55

Update _lookup.py

a669134

Update _lookup.py

d78bf5d

[ENH] EXPERIMENTAL PR: D1 and D2 layer for v2 refactor (sktime#1811)

3d2dafc

### Description This PR implements the basic skeleton of D1 and D2 layer for v2. See sktime#1736 for discussion and design.

[BUG] EXPERIMENTAL PR: Solve the bug in data_module (sktime#1834)

15ea3c3

This PR solves the bug in `data_module` where the `static_categorical_features` and `static_continuous_features` were not correctly calculated in `__getitem__` of nested class

[BUG] fix incorrect concatenation dimension in concat_sequences (sk…

c04ebf3

…time#1827) ### Description This PR fixes [1823](sktime#1823)

[ENH] EXPERIMENTAL PR: make the data_module dataclass-like (sktime#…

524d05b

…1832) This PR makes the `data_modulel` dataclass-like See discussion in sktime#1829

add initial version of tests for tide

b82b42a

PranavBhatP requested review from benHeid, fkiraly, fnhirwa, jdb78 and yarnabrina as code owners May 22, 2025 11:24

fkiraly requested changes May 23, 2025

View reviewed changes

Merge branch 'main' into test-tide-stack-1780

4613d1b

PranavBhatP requested a review from fkiraly May 23, 2025 07:19

fkiraly requested changes May 26, 2025

View reviewed changes

PranavBhatP added 2 commits May 27, 2025 16:14

add metadata class for tide

f23d4d1

add TiDEModelMetadata to __init__.py

228c2f1

fixed model-specific changes to provide test compatibility to TiDE

9be3f11

fkiraly reviewed May 27, 2025

View reviewed changes

fkiraly changed the title ~~[ENH] add tests for TiDE Model.~~ [ENH] tests for TiDE Model. May 27, 2025

fkiraly moved this from PR in progress to PR under review in May - Sep 2025 mentee projects May 28, 2025

Merge branch 'main' into pr/1843

52d763c

fkiraly approved these changes May 28, 2025

View reviewed changes

fkiraly changed the title ~~[ENH] tests for TiDE Model.~~ [ENH] tests for TiDE Model May 29, 2025

fkiraly merged commit 756f61a into sktime:main May 29, 2025
35 checks passed

github-project-automation bot moved this from PR under review to Done in May - Sep 2025 mentee projects May 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ENH] tests for `TiDE` Model #1843

[ENH] tests for `TiDE` Model #1843

Uh oh!

PranavBhatP commented May 22, 2025

Uh oh!

codecov bot commented May 22, 2025 •

edited

Loading

Uh oh!

fkiraly left a comment

Uh oh!

PranavBhatP commented May 23, 2025 •

edited

Loading

Uh oh!

phoeenniixx commented May 23, 2025

Uh oh!

PranavBhatP commented May 25, 2025

Uh oh!

fkiraly left a comment

Uh oh!

PranavBhatP commented May 27, 2025 •

edited

Loading

Uh oh!

fkiraly left a comment

Uh oh!

fkiraly left a comment

Uh oh!

PranavBhatP commented May 28, 2025 •

edited

Loading

Uh oh!

fkiraly commented May 28, 2025 •

edited

Loading

Uh oh!

PranavBhatP commented May 28, 2025 •

edited

Loading

Uh oh!

fkiraly commented May 29, 2025

Uh oh!

Uh oh!

PranavBhatP commented May 29, 2025

Uh oh!

Uh oh!

[ENH] tests for TiDE Model #1843

[ENH] tests for TiDE Model #1843

Uh oh!

Conversation

PranavBhatP commented May 22, 2025

Description

Checklist

Uh oh!

codecov bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

fkiraly left a comment

Choose a reason for hiding this comment

Uh oh!

PranavBhatP commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phoeenniixx commented May 23, 2025

Uh oh!

PranavBhatP commented May 25, 2025

Uh oh!

fkiraly left a comment

Choose a reason for hiding this comment

Uh oh!

PranavBhatP commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fkiraly left a comment

Choose a reason for hiding this comment

Uh oh!

fkiraly left a comment

Choose a reason for hiding this comment

Uh oh!

PranavBhatP commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fkiraly commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PranavBhatP commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fkiraly commented May 29, 2025

Uh oh!

Uh oh!

PranavBhatP commented May 29, 2025

Uh oh!

Uh oh!

[ENH] tests for `TiDE` Model #1843

[ENH] tests for `TiDE` Model #1843

codecov bot commented May 22, 2025 •

edited

Loading

PranavBhatP commented May 23, 2025 •

edited

Loading

PranavBhatP commented May 27, 2025 •

edited

Loading

PranavBhatP commented May 28, 2025 •

edited

Loading

fkiraly commented May 28, 2025 •

edited

Loading

PranavBhatP commented May 28, 2025 •

edited

Loading