Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Remove reshape stub #2826

Merged
merged 2 commits into from
Aug 2, 2024
Merged

[python] Remove reshape stub #2826

merged 2 commits into from
Aug 2, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 2, 2024

Issue and/or context: The reshape method is not part of the SOMA spec. And it is raising NotImplementedError so no one can be using it. This needs to be GC'ed. This is a split-out from PR #2785 for issue #2407. See also [sc-51048].

Changes:

Notes for Reviewer:

@johnkerl johnkerl merged commit a2d582e into main Aug 2, 2024
5 of 9 checks passed
@johnkerl johnkerl deleted the kerl/no-reshape branch August 2, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants