Skip to content

Commit

Permalink
[python] Remove reshape stub (#2826)
Browse files Browse the repository at this point in the history
* [python] Remove `reshape stub

* fix unit-test case
  • Loading branch information
johnkerl authored Aug 2, 2024
1 parent d6e0719 commit a2d582e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 19 deletions.
8 changes: 0 additions & 8 deletions apis/python/src/tiledbsoma/_common_nd_array.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,6 @@ def shape(self) -> Tuple[int, ...]:
"""
return cast(Tuple[int, ...], tuple(self._handle.shape))

def reshape(self, shape: Tuple[int, ...]) -> None:
"""Unsupported operation for this object type.
Lifecycle:
Maturing.
"""
raise NotImplementedError("reshape operation not implemented.")

@classmethod
def _dim_capacity_and_extent(
cls,
Expand Down
11 changes: 0 additions & 11 deletions apis/python/tests/test_dense_nd_array.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,17 +173,6 @@ def test_zero_length_fail(tmp_path, shape):
soma.DenseNDArray.create(tmp_path.as_posix(), type=pa.float32(), shape=shape)


def test_dense_nd_array_reshape(tmp_path):
"""
Reshape currently unimplemented.
"""
a = soma.DenseNDArray.create(
tmp_path.as_posix(), type=pa.int32(), shape=(10, 10, 10)
)
with pytest.raises(NotImplementedError):
assert a.reshape((100, 10, 1))


@pytest.mark.parametrize("shape_is_numeric", [True, False])
def test_dense_nd_array_requires_shape(tmp_path, shape_is_numeric):
uri = tmp_path.as_posix()
Expand Down

0 comments on commit a2d582e

Please sign in to comment.