-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Updated installation and contribution documentation #4148
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7a4e19e
Fix links
t20100 33b20a1
Rework and simplify installation doc; remove virtual env doc
t20100 413229f
update contribution doc
t20100 fabe07e
remove MatplotlibBackend from doc to avoid issues with matplotlib custom
t20100 b8e95c9
Fix warning
t20100 d908d5d
shorter PR template
t20100 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,23 @@ | ||
How to contribute to *silx* | ||
=========================== | ||
How to contribute | ||
================= | ||
|
||
This document describes how to contribute to the *silx* project. | ||
The process is similar to many other open-source projects like *numpy*, just lighter as the project is smaller, so you won't be surprised with the pipeline. | ||
|
||
*scikit-image* provides a nice tutorial in `their own CONTRIBUTING guide`_. | ||
Development process | ||
------------------- | ||
|
||
This project follows the standard open-source project github workflow, | ||
which is described in other projects like `scikit-image <https://scikit-image.org/docs/stable/development/contribute.html>`_. | ||
|
||
1. Create your GitHub account `https://help.github.com/categories/setup/` | ||
and upload your SSH keys. | ||
1. Create your `GitHub <https://github.com/>`_ account and upload your SSH keys. | ||
|
||
2. Fork the silx project from `https://github.com/silx-kit/silx/`. | ||
The button is on the top right of the page. | ||
2. Fork the silx project from https://github.com/silx-kit/silx/. | ||
|
||
3. Clone your GitHub version locally on the computer you intend to work on. | ||
3. Clone your GitHub repository on yout local computer. | ||
|
||
.. code-block:: bash | ||
|
||
git clone [email protected]/<your_user_name>/silx | ||
cd silx | ||
|
||
4. Install the dependencies defined in *requirements-dev.txt*. | ||
|
||
|
@@ -42,16 +42,17 @@ The process is similar to many other open-source projects like *numpy*, just lig | |
|
||
10. Create a pull request (PR) from your feature branch on GitHub to trigger | ||
the review process. Indicate this PR is related to the issue you opened in 6. | ||
Make sure to follow the `Pull Request title format`_. | ||
|
||
11. Discuss with the maintainer who is reviewing your code using the GitHub interface. | ||
|
||
If you encounter any problems or have any questions you can always ask on the `Issues page`_. | ||
If you encounter any problems or have any questions you can always ask on the `Issues page <https://github.com/silx-kit/silx/issues>`_. | ||
|
||
|
||
Pull Request title format | ||
------------------------- | ||
|
||
To ease release notes authoring, please use the following syntax for the title of your Pull Requests (PR):: | ||
To ease release notes authoring, when creating a Pull Request (PR), please use the following syntax for the title:: | ||
|
||
<Subpackage/Module/Topic>: <Action> <summary of the main change affecting silx's users> | ||
|
||
|
@@ -79,8 +80,46 @@ With: | |
|
||
- **Summary**: A short description of the main change as you would like to read it from release notes. | ||
|
||
.. _their own CONTRIBUTING guide: https://github.com/scikit-image/scikit-image/blob/3736339272b9d129f98fc723b508ac5490c171fa/CONTRIBUTING.rst | ||
.. _Issues page: https://github.com/silx-kit/silx/issues | ||
|
||
Code formatting | ||
--------------- | ||
|
||
To format the code, use `black <https://black.readthedocs.io>`_. | ||
|
||
|
||
How-to build the documentation | ||
------------------------------ | ||
|
||
To build the documentation, using `Sphinx <http://www.sphinx-doc.org/>`_, run: | ||
|
||
.. code-block:: bash | ||
|
||
pip install . # Make sure to install the same version as the source | ||
sphinx-build doc/source/ build/html | ||
|
||
.. note:: | ||
|
||
To re-generate the example script screenshots, build the documentation with the | ||
environment variable ``DIRECTIVE_SNAPSHOT_QT`` set to ``True``. | ||
|
||
|
||
How-to run the tests | ||
-------------------- | ||
|
||
To run the tests of an installed version of *silx*, run the following on the python interpreter: | ||
|
||
.. code-block:: python | ||
|
||
import silx.test | ||
silx.test.run_tests() | ||
|
||
To run the test suite of a development version, use the *run_tests.py* script at | ||
the root of the source project. | ||
|
||
.. code-block:: bash | ||
|
||
python ./run_tests.py | ||
|
||
|
||
How-to make a release | ||
--------------------- | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
.. include:: ../../CONTRIBUTING.rst |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved documentation from installation to contribution