silx.gui.plot.PlotWidget: Improved line dash rendering for OpenGL backend #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
Dec 18, 2023
| _DASH_PATTERNS = { # Convert from linestyle to dash pattern | ||
| "": None, | ||
| " ": None, | ||
| "-": (), |
There was a problem hiding this comment.
Empty tuple = solid line (no dashes). Not really nice but simple.
vallsv
approved these changes
Dec 19, 2023
|
Rebase to fix conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the rendering of dashed lines in the OpenGL backend to make it more consistent with the matplotlib backend.
It aims at making dashes behaves the same as the matplotlib backend and the same between
ShapeandCurve.There is a limitation due to OpenGL is that the available line width can be limited by the OpenGL implementation (this PR does not aim at mitigating that).
It also paves the way in the OpenGL backend to provide the line style as
(offset, dash pattern)by centralizing the conversion oflinestyleto dash pattern early.related to #4010