Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx.gui.plot.PlotWidget: Added support of line style defined as (offset, (dash pattern)) #4020

Merged
merged 11 commits into from
Dec 20, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Dec 19, 2023

This PR adds support in both PlotWidget backends of line style as (offset, (dash pattern)) the same way matploltib Line2D supports it.
Previous string based styles (e.g., '--', '-.') are still supported.

related to #4005 and #4010, follow up of #4015

This still need some tests.

@t20100 t20100 added this to the 2.0.0 milestone Dec 19, 2023
@t20100 t20100 marked this pull request as ready for review December 20, 2023 09:35
@t20100 t20100 requested a review from vallsv December 20, 2023 09:36
@t20100
Copy link
Member Author

t20100 commented Dec 20, 2023

Added support of (offset, (dash pattern)) in LegendSelector and added tests of different items with line style + test for the LegendSelector.

Ready for review

@vallsv vallsv merged commit ebed82b into silx-kit:main Dec 20, 2023
6 of 7 checks passed
@t20100 t20100 deleted the line-dash2 branch January 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants