Skip to content

refactor(migrations): optimize icon migration performance #8985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamja44 wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −4
Open

refactor(migrations): optimize icon migration performance #8985

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51dde0b
refactor(migrations): optimize icon migration performance
kamja44 Dec 8, 2025
3018cc3
Merge branch 'main' into refactor/optimize-icon-migration
kamja44 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/shadcn/src/migrations/migrate-icons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,15 @@ export async function migrateIconsFile(
scriptKind: ScriptKind.TSX,
})

const sourceToTargetMap = new Map<string, string>()
for (const iconEntry of Object.values(iconsMapping)) {
const sourceIconName = iconEntry[sourceLibrary]
const targetIconName = iconEntry[targetLibrary]
if (sourceIconName && targetIconName) {
sourceToTargetMap.set(sourceIconName, targetIconName)
}
}

// Find all sourceLibrary imports.
let targetedIcons: string[] = []
for (const importDeclaration of sourceFile.getImportDeclarations() ?? []) {
Expand All @@ -161,10 +170,7 @@ export async function migrateIconsFile(
for (const specifier of importDeclaration.getNamedImports() ?? []) {
const iconName = specifier.getName()

// TODO: this is O(n^2) but okay for now.
const targetedIcon = Object.values(iconsMapping).find(
(icon) => icon[sourceLibrary] === iconName
)?.[targetLibrary]
const targetedIcon = sourceToTargetMap.get(iconName)

if (!targetedIcon || targetedIcons.includes(targetedIcon)) {
continue
Expand Down