refactor(migrations): optimize icon migration performance #8985
+10
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes icon migration performance by replacing O(n²) array search with O(1) Map lookups.
Problem
The current implementation uses
Object.values().find()for every imported icon, resulting in O(n²) time complexity. With large icon mappings (500+ icons), this becomes noticeably slow.Solution
sourceToTargetMap) once at the startMap.get()for O(1) lookups instead of array searchesPerformance Impact
Example: 50 imported icons, 500 total mappings
Changes
sourceToTargetMapconstruction before processing importsObject.values().find()withMap.get()Testing
Checklist
Resolves TODO comment at line 164.