Render class rasters through pysepal's add_raster - #23
Open
dfguerrerom wants to merge 1 commit into
Open
Conversation
Categorical rendering was never app-specific: the discrete LUT, the server-side registration that keeps per-class alpha, and the COG preparation now live in SepalMap.add_raster behind class_colors. SbaeMap just inherits it, so the local add_class_raster, _optimize_for_tiles, _build_class_colormap and scripts/tiling.py all go, and the inert LOCALTILESERVER_HOST knob goes with the TileClient call that carried it. classification_layer was assigned twice and read nowhere; dropped. Needs pysepal 3.9.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup item (h), and (e) falls out with it.
Stacked on #22 — review that one first. This PR targets
cleanup/tile-band-aidsso its diff shows only the raster work; GitHub will retarget it tomainonce #22 merges.Categorical rendering was never app-specific, so the discrete LUT, the server-side registration that preserves per-class alpha, and the COG preparation now live in
SepalMap.add_rasterbehind aclass_colorsparameter.SbaeMapinherits it, which removes the localadd_class_raster,_optimize_for_tiles,_build_class_colormapandscripts/tiling.py. The inertLOCALTILESERVER_HOSTknob goes with the TileClient call that carried it — nothing set it, and TileClient already defaulted to 127.0.0.1.Call sites moved to keywords:
add_raster's positional order differs from the old method's, so the previous positional calls would have boundlayer_nametobands.Blocked on pysepal 3.9.0 and vectortileserver 0.2.2. Tests: 195 passed.