Skip to content

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0 #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@typescript-eslint/eslint-plugin": "8.54.0",
Copy link
Contributor

@llamapreview llamapreview bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Contextual Comment]
This comment refers to code near real line 69. Anchored to nearest_changed(72) line 72.

P2 | Confidence: High

Speculative: This PR updates ESLint from v9.39.2 to v10.0.0, a major version containing numerous breaking changes (as listed in the PR description). The CI status shows that Lint & Type Check, Test (Fast), and Test Coverage jobs have failed immediately after this version bump. The most likely cause is incompatibility between ESLint v10 and the current ESLint configuration or plugins. Crucially, the related_context search for .eslintrc files returned no results, suggesting the project's ESLint configuration might be missing from the provided context or is in an unexpected format. However, given that @typescript-eslint/eslint-plugin and @typescript-eslint/parser are pinned to version 8.54.0 (a version likely incompatible with ESLint v10), this will almost certainly cause the linting process to fail. The breaking changes (like removing eslintrc support, stricter rule tester assertions, and dropping support for jiti < 2.2.0) are major and non-backward compatible.

The update to ESLint v10.0.0 mandates a higher minimum Node.js version (^20.19.0 || ^22.13.0 || >=24), as stated in the breaking changes. The project's current Node.js version requirement is not visible in the provided package.json snippet. If the development or CI environment uses an older Node.js version (e.g., Node 18), ESLint v10 will fail to run, which would explain the immediate CI test failures. This is a hard runtime dependency that must be satisfied.

Speculative: The test failures (Test (Fast), Test Coverage) are likely a secondary effect of the ESLint update. Vitest may be configured to run ESLint as part of its pre-test or test setup, or the project's test files may be subject to linting rules that are now broken due to the major version change. A breaking change like "stricter rule tester assertions for valid test cases" could cause previously passing test suites that validate custom ESLint rules to fail. Without the test configuration or custom rule files, this remains speculative but is a common failure pattern when upgrading ESLint in a project with integrated lint-test workflows.

Code Suggestion:

"engines": {
  "node": "^20.19.0 || ^22.13.0 || >=24"
}

Evidence: path:.eslintrc*, path:vitest.config.*

"@typescript-eslint/parser": "^8.54.0",
"@vitest/coverage-v8": "^4.0.18",
"eslint": "^9.39.2",
"eslint": "^10.0.0",
"memfs": "4.56.10",
"typescript": "^5.7.2",
"vitest": "^4.0.18"
Expand Down
Loading