chore(deps-dev): bump eslint from 9.39.2 to 10.0.0 #17
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.2 to 10.0.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.2...v10.0.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
![llamapreview[bot]](https://avatars.githubusercontent.com/in/1023541?s=60&v=4){kind=small}
There was a problem hiding this comment.
AI Code Review by LlamaPReview
🎯 TL;DR & Recommendation
Recommendation: Approve with suggestions.
This PR updates ESLint to v10.0.0, a major version with breaking changes that could disrupt linting due to incompatible plugins, require Node.js version updates, and cause test failures from integration issues.
| Priority | File | Category | Impact Summary | Anchors |
|---|---|---|---|---|
| P2 | package.json | Architecture | ESLint v10 may break linting due to incompatible plugins. | path:.eslintrc* |
| P2 | package.json | Maintainability | Node.js version mismatch could fail ESLint execution. | |
| P2 | package.json | Testing | Test failures likely from ESLint integration changes. | path:vitest.config.* |
🔍 Notable Themes
- All issues stem from the ESLint v10 major upgrade, requiring updates to configuration, dependencies, and environment settings to maintain CI/CD pipeline stability.
💡 Have feedback? We'd love to hear it in our GitHub Discussions.
✨ This review was generated by LlamaPReview Advanced, which is free for all open-source projects. Learn more.
| @@ -72,7 +72,7 @@ | |||
| "@typescript-eslint/eslint-plugin": "8.54.0", | |||
There was a problem hiding this comment.
[Contextual Comment]
This comment refers to code near real line 69. Anchored to nearest_changed(72) line 72.
P2 | Confidence: High
Speculative: This PR updates ESLint from v9.39.2 to v10.0.0, a major version containing numerous breaking changes (as listed in the PR description). The CI status shows that Lint & Type Check, Test (Fast), and Test Coverage jobs have failed immediately after this version bump. The most likely cause is incompatibility between ESLint v10 and the current ESLint configuration or plugins. Crucially, the related_context search for .eslintrc files returned no results, suggesting the project's ESLint configuration might be missing from the provided context or is in an unexpected format. However, given that @typescript-eslint/eslint-plugin and @typescript-eslint/parser are pinned to version 8.54.0 (a version likely incompatible with ESLint v10), this will almost certainly cause the linting process to fail. The breaking changes (like removing eslintrc support, stricter rule tester assertions, and dropping support for jiti < 2.2.0) are major and non-backward compatible.
The update to ESLint v10.0.0 mandates a higher minimum Node.js version (^20.19.0 || ^22.13.0 || >=24), as stated in the breaking changes. The project's current Node.js version requirement is not visible in the provided package.json snippet. If the development or CI environment uses an older Node.js version (e.g., Node 18), ESLint v10 will fail to run, which would explain the immediate CI test failures. This is a hard runtime dependency that must be satisfied.
Speculative: The test failures (Test (Fast), Test Coverage) are likely a secondary effect of the ESLint update. Vitest may be configured to run ESLint as part of its pre-test or test setup, or the project's test files may be subject to linting rules that are now broken due to the major version change. A breaking change like "stricter rule tester assertions for valid test cases" could cause previously passing test suites that validate custom ESLint rules to fail. Without the test configuration or custom rule files, this remains speculative but is a common failure pattern when upgrading ESLint in a project with integrated lint-test workflows.
Code Suggestion:
"engines": {
"node": "^20.19.0 || ^22.13.0 || >=24"
}Evidence: path:.eslintrc*, path:vitest.config.*
1 participant
Bumps eslint from 9.39.2 to 10.0.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
4e6c4ac10.0.0ddd8a22Build: changelog update for 10.0.0bff9091feat: handleArray.fromAsyncinarray-callback-return(#20457)1ece282chore: ignore/docs/v9.xin link checker (#20452)034e139ci: add type integration test for@html-eslint/eslint-plugin(#20345)f3fbc2fchore: set@eslint/jsversion to 10.0.0 to skip releasing it (#20466)e978ddadocs: Update README4cecf83docs: Update READMEc79f0abdocs: Update READMEafc0681chore: remove scopeManager.addGlobals patch for typescript-eslint parser (#20...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)