Skip to content

RFC: pnpm config dependency#2188

Merged
samchungy merged 84 commits intomainfrom
rfc-pnpm-config-skuba
Mar 4, 2026
Merged

RFC: pnpm config dependency#2188
samchungy merged 84 commits intomainfrom
rfc-pnpm-config-skuba

Conversation

@samchungy
Copy link
Contributor

@samchungy samchungy commented Dec 22, 2025

Migrate to https://pnpm.io/config-dependencies to simplify our pnpm setup

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

🦋 Changeset detected

Latest commit: 5b94f8c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zbrydon
Copy link
Contributor

zbrydon commented Dec 27, 2025

TODO: I have no idea how we're gonna get the sha in

Think we need to do this once it's published, then we can start using it 🤔
pnpm view @skuba-lib/pnpm-config-skuba@1.0.0 dist.integrity

@samchungy
Copy link
Contributor Author

TODO: I have no idea how we're gonna get the sha in

Think we need to do this once it's published, then we can start using it 🤔 pnpm view @skuba-lib/pnpm-config-skuba@1.0.0 dist.integrity

The challenge with that might be how our integration test would work 🥲

@samchungy
Copy link
Contributor Author

TODO: I have no idea how we're gonna get the sha in

Think we need to do this once it's published, then we can start using it 🤔 pnpm view @skuba-lib/pnpm-config-skuba@1.0.0 dist.integrity

The challenge with that might be how our integration test would work 🥲

We might need to apply an integration only test which uses a symlinked .pnpmfile.cjs like what I've done for the root of this repo. Then we dynamically call like you suggested pnpm view @skuba-lib/pnpm-config-skuba@1.0.0 dist.integrity on a new pnpm init?

@samchungy samchungy changed the title RFC: pnpm-config-skuba RFC: pnpmfile Jan 6, 2026
@samchungy samchungy changed the title RFC: pnpmfile RFC: pnpm config dependency Jan 6, 2026
@samchungy samchungy merged commit 7f54e66 into main Mar 4, 2026
17 checks passed
@samchungy samchungy deleted the rfc-pnpm-config-skuba branch March 4, 2026 23:26
@seek-oss-ci seek-oss-ci mentioned this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants