Open
Conversation
cbfb334 to
a44e018
Compare
c6bdb50 to
098fe88
Compare
098fe88 to
5f781a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
skuba@15.0.0
Major Changes
build-package: Migrate to tsdown (#2194)
As part of our migration to ESM, we are updating our package build process to support generating both CJS and ESM outputs, regardless of whether projects use CJS or ESM. Since our current tsc-based build does not support this, we are switching to tsdown for package builds.
lint: Migrate
skuba build-packageusage to use tsdown for building packages (#2194)This patch will attempt to do a best effort migration of your
skuba build-packageusage to use tsdown for building packages. This includes:tsdown.config.mtsfile to your package directories with a basic configurationcustomConditionsentry to your roottsconfig.jsonfileskipLibCheckto your packagetsconfig.jsonfiles to work around issues with type checking againsttsdown.package.jsonfiles to point to the new build outputstsconfig.build.jsonfilesFile changes
The output between what
skuba build-packagegenerates before and after this change will be different, so you may need to update any references to the output files in your project.For example the output for a simple
src/index.tsfile produces the following outputs:This change may break consumers who directly access these output paths.
To check if your consumers are affected, search GitHub with:
org:SEEK-Jobs content:"@seek/MY_PACKAGE/"If needed, export those references from your package entry point to help consumers migrate to the new build outputs.
Note: if you choose to remove the
unbundle: trueoption fromtsdown.config.mts, tsdown may emit bundled/chunked outputs and internallib/...file paths can change between builds. Consumers should avoid importing from build output files directly, and instead import from the package entry point (or explicitly exported sub paths)Format changes
tsdownselects what ECMAScript target version to build for based on theengines.nodefield in yourpackage.json.This means that for consumers previously relying on the
lib-es2015output may need to update their runtime to match your package'sengines.nodefield.An example changeset you may want to include for a package:
Debugging
If your project utilises a
mainfield which points to a.tsfile within a monorepo setup, eg.You may need to create a
moduleNameMapperentry in your Jest config files to point to the source file, eg.This will work natively with custom conditions when we migrate to
vitestin the future, but is required for Jest to continue working with the new build outputs.Minor Changes
template/*-npm-package: Migrate to
tsdownfor bundling (#2193)lint: Ignore
coverage,dist,libandtmpfolders at any depth (#2256)Patch Changes
deps: @ast-grep/napi ^0.41.0 (#2245)
template/lambda-sqs-worker-cdk: Update Datadog secret configuration to support custom KMS keys (#2239)
eslint-config-skuba@8.1.0
Minor Changes
coverage,dist,libandtmpfolders at any depth (#2256)eslint-plugin-skuba@2.0.1
Patch Changes
@skuba-lib/vitest-koa-mocks@1.0.1
Patch Changes