fix(SelectInput): html tag options #5586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisalupi
requested review from
fabienhebert and
Lawndlwd
and removed request for
a team
lisalupi
requested review from
johnrazeur,
a team and
matthprost
as code owners
🦋 Changeset detectedLatest commit: ff69bd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lisalupi
force-pushed
the
fix/select-input-html-tag
branch
from
7c82ddc to
e172094
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## beta #5586 +/- ##
=======================================
Coverage 92.19% 92.20%
=======================================
Files 274 283 +9
Lines 7807 7739 -68
Branches 3264 3206 -58
=======================================
- Hits 7198 7136 -62
+ Misses 609 603 -6
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
matthprost
approved these changes
Sep 25, 2025
radhi-nasser-scaleway
approved these changes
Sep 25, 2025
lisalupi
force-pushed
the
fix/select-input-html-tag
branch
from
e172094 to
ff69bd9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
SelectInput: placeholder should be aspaninstead of ap