Skip to content

Commit 943b05a

Browse files
lisalupilisalupi
authored
fix: html tag select input option (#5586)
1 parent 660d30e commit 943b05a

File tree

19 files changed

+323
-318
lines changed

19 files changed

+323
-318
lines changed

‎.changeset/plain-windows-add.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@ultraviolet/ui": patch
3+
---
4+
5+
`SelectInput`: placeholder shoul be a `span` instead of a `p`

‎packages/form/src/components/SelectInputField/__tests__/__snapshots__/index.test.tsx.snap‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -276,11 +276,11 @@ exports[`selectInputField > should display right value on grouped options 1`] =
276276
role="combobox"
277277
tabindex="0"
278278
>
279-
<div
279+
<span
280280
class="emotion-4 emotion-5 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9owm uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
281281
>
282282
Mercury
283-
</div>
283+
</span>
284284
<div
285285
class="emotion-6 emotion-7 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
286286
>
@@ -787,11 +787,11 @@ exports[`selectInputField > should render correctly 1`] = `
787787
role="combobox"
788788
tabindex="0"
789789
>
790-
<p
790+
<span
791791
class="emotion-4 emotion-5 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owl uv_m4c9owm uv_m4c9ow1b uv_m4c9ow23 uv_m4c9ow3f"
792792
>
793793
Select item
794-
</p>
794+
</span>
795795
<div
796796
class="emotion-6 emotion-7 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
797797
>
@@ -968,11 +968,11 @@ exports[`selectInputField > should render correctly disabled 1`] = `
968968
role="combobox"
969969
tabindex="0"
970970
>
971-
<p
971+
<span
972972
class="emotion-4 emotion-5 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owl uv_m4c9owm uv_m4c9ow1a uv_m4c9ow33"
973973
>
974974
Select item
975-
</p>
975+
</span>
976976
<div
977977
class="emotion-6 emotion-7 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
978978
>
@@ -1149,11 +1149,11 @@ exports[`selectInputField > should render correctly grouped 1`] = `
11491149
role="combobox"
11501150
tabindex="0"
11511151
>
1152-
<p
1152+
<span
11531153
class="emotion-4 emotion-5 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owl uv_m4c9owm uv_m4c9ow1b uv_m4c9ow23 uv_m4c9ow3f"
11541154
>
11551155
Select item
1156-
</p>
1156+
</span>
11571157
<div
11581158
class="emotion-6 emotion-7 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
11591159
>
@@ -1330,11 +1330,11 @@ exports[`selectInputField > should render correctly multiselect 1`] = `
13301330
role="combobox"
13311331
tabindex="0"
13321332
>
1333-
<p
1333+
<span
13341334
class="emotion-4 emotion-5 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owl uv_m4c9owm uv_m4c9ow1b uv_m4c9ow23 uv_m4c9ow3f"
13351335
>
13361336
Select item
1337-
</p>
1337+
</span>
13381338
<div
13391339
class="emotion-6 emotion-7 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
13401340
>
@@ -1510,11 +1510,11 @@ exports[`selectInputField > should trigger events 1`] = `
15101510
role="combobox"
15111511
tabindex="0"
15121512
>
1513-
<div
1513+
<span
15141514
class="emotion-4 emotion-5 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9owm uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
15151515
>
15161516
Mercury
1517-
</div>
1517+
</span>
15181518
<div
15191519
class="emotion-6 emotion-7 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
15201520
>

‎packages/form/src/components/SelectableCardOptionGroupField/__tests__/__snapshots__/index.test.tsx.snap‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -448,11 +448,11 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
448448
role="combobox"
449449
tabindex="0"
450450
>
451-
<div
451+
<span
452452
class="emotion-20 emotion-21 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9own uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
453453
>
454454
Ubuntu 20.04 Focal Fossa
455-
</div>
455+
</span>
456456
<div
457457
class="emotion-22 emotion-23 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
458458
>
@@ -594,11 +594,11 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
594594
role="combobox"
595595
tabindex="0"
596596
>
597-
<p
597+
<span
598598
class="emotion-42 emotion-43 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owl uv_m4c9own uv_m4c9ow1b uv_m4c9ow23 uv_m4c9ow3f"
599599
>
600600
Select item
601-
</p>
601+
</span>
602602
<div
603603
class="emotion-22 emotion-23 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
604604
>
@@ -740,11 +740,11 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
740740
role="combobox"
741741
tabindex="0"
742742
>
743-
<p
743+
<span
744744
class="emotion-42 emotion-43 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owl uv_m4c9own uv_m4c9ow1b uv_m4c9ow23 uv_m4c9ow3f"
745745
>
746746
Select item
747-
</p>
747+
</span>
748748
<div
749749
class="emotion-22 emotion-23 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
750750
>

‎packages/form/src/components/UnitInputField/__tests__/__snapshots__/index.test.tsx.snap‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -409,11 +409,11 @@ exports[`unitInputField > should handles onChange and selection 1`] = `
409409
role="combobox"
410410
tabindex="0"
411411
>
412-
<div
412+
<span
413413
class="emotion-11 emotion-12 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9owm uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
414414
>
415415
Days
416-
</div>
416+
</span>
417417
<div
418418
class="emotion-13 emotion-14 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
419419
>
@@ -845,11 +845,11 @@ exports[`unitInputField > should render correctly 1`] = `
845845
role="combobox"
846846
tabindex="0"
847847
>
848-
<p
848+
<span
849849
class="emotion-11 emotion-12 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owl uv_m4c9owm uv_m4c9ow1b uv_m4c9ow23 uv_m4c9ow3f"
850850
>
851851
Select item
852-
</p>
852+
</span>
853853
<div
854854
class="emotion-13 emotion-14 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
855855
>

‎packages/plus/src/components/EstimateCost/__tests__/__snapshots__/CustomUnitInput.test.tsx.snap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,11 +390,11 @@ exports[`estimateCost - CustomUnitInput > render default values 1`] = `
390390
role="combobox"
391391
tabindex="0"
392392
>
393-
<div
393+
<span
394394
class="emotion-11 emotion-12 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9own uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
395395
>
396396
Hour(s)
397-
</div>
397+
</span>
398398
<div
399399
class="emotion-13 emotion-14 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
400400
>

‎packages/plus/src/components/EstimateCost/__tests__/__snapshots__/Item.test.tsx.snap‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1493,11 +1493,11 @@ exports[`estimateCost - Item > render with labelTextVariant 1`] = `
14931493
role="combobox"
14941494
tabindex="0"
14951495
>
1496-
<div
1496+
<span
14971497
class="emotion-45 emotion-46 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9own uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
14981498
>
14991499
Hour(s)
1500-
</div>
1500+
</span>
15011501
<div
15021502
class="emotion-47 emotion-48 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
15031503
>
@@ -2443,11 +2443,11 @@ exports[`estimateCost - Item > render with noPrice and noBorder 1`] = `
24432443
role="combobox"
24442444
tabindex="0"
24452445
>
2446-
<div
2446+
<span
24472447
class="emotion-45 emotion-46 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9own uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
24482448
>
24492449
Hour(s)
2450-
</div>
2450+
</span>
24512451
<div
24522452
class="emotion-47 emotion-48 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
24532453
>
@@ -4055,11 +4055,11 @@ exports[`estimateCost - Item > render with notice 1`] = `
40554055
role="combobox"
40564056
tabindex="0"
40574057
>
4058-
<div
4058+
<span
40594059
class="emotion-47 emotion-48 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9own uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
40604060
>
40614061
Hour(s)
4062-
</div>
4062+
</span>
40634063
<div
40644064
class="emotion-49 emotion-50 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
40654065
>
@@ -5669,11 +5669,11 @@ exports[`estimateCost - Item > render with priceText 1`] = `
56695669
role="combobox"
56705670
tabindex="0"
56715671
>
5672-
<div
5672+
<span
56735673
class="emotion-45 emotion-46 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9own uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
56745674
>
56755675
Hour(s)
5676-
</div>
5676+
</span>
56775677
<div
56785678
class="emotion-47 emotion-48 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
56795679
>
@@ -7262,11 +7262,11 @@ exports[`estimateCost - Item > render with tabulation 1`] = `
72627262
role="combobox"
72637263
tabindex="0"
72647264
>
7265-
<div
7265+
<span
72667266
class="emotion-45 emotion-46 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9own uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
72677267
>
72687268
Hour(s)
7269-
</div>
7269+
</span>
72707270
<div
72717271
class="emotion-47 emotion-48 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
72727272
>
@@ -8895,11 +8895,11 @@ exports[`estimateCost - Item > render with tooltipInfo 1`] = `
88958895
role="combobox"
88968896
tabindex="0"
88978897
>
8898-
<div
8898+
<span
88998899
class="emotion-47 emotion-48 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9own uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
89008900
>
89018901
Hour(s)
8902-
</div>
8902+
</span>
89038903
<div
89048904
class="emotion-49 emotion-50 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
89058905
>

‎packages/plus/src/components/EstimateCost/__tests__/__snapshots__/Region.test.tsx.snap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -848,11 +848,11 @@ exports[`estimateCost - Region > render region component 1`] = `
848848
role="combobox"
849849
tabindex="0"
850850
>
851-
<div
851+
<span
852852
class="emotion-47 emotion-48 uv_m4c9ow0 uv_m4c9ow2 uv_m4c9ow4 uv_m4c9ow6 uv_m4c9ow8 uv_m4c9owb uv_m4c9owi uv_m4c9own uv_m4c9ow1b uv_m4c9ow20 uv_m4c9ow3c"
853853
>
854854
Hour(s)
855-
</div>
855+
</span>
856856
<div
857857
class="emotion-49 emotion-50 uv_toi52u0 uv_toi52u3d uv_toi52u2j uv_toi52u7d uv_toi52u7 uv_toi52u5d"
858858
>

0 commit comments

Comments
 (0)