Skip to content

Fix an issue triggered by long input to load_jinja2_template #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junya-takayama merged 1 commit into from
Nov 14, 2025
+11 −2
Merged

Fix an issue triggered by long input to load_jinja2_template #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions flexeval/core/chat_dataset/template_based.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,12 @@

def load_jinja2_template(template: str | PathLike[str]) -> Template:
path = Path(template)
if path.exists():
return JINJA2_ENV.from_string(path.read_text(encoding="utf-8"))
try:
if path.exists():
return JINJA2_ENV.from_string(path.read_text(encoding="utf-8"))
except OSError:
# If the template is a very long string, path.exists() emits an OSError.
pass
return JINJA2_ENV.from_string(template)


Expand Down
5 changes: 5 additions & 0 deletions tests/core/chat_dataset/test_template_based.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,3 +221,8 @@ def test_load_jinja2_template(dummy_template_file: Path) -> None:
embed_result = template_from_string.render(name="flexeval")
assert isinstance(template_from_string, Template)
assert embed_result == "Hello flexeval!"

template_from_string = load_jinja2_template("a" * 1000)
embed_result = template_from_string.render()
assert isinstance(template_from_string, Template)
assert embed_result == "a" * 1000