Fix an issue triggered by long input to load_jinja2_template
#260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junya-takayama
approved these changes
Nov 14, 2025
Collaborator
junya-takayama
left a comment
junya-takayama
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#252 enhanced load_jinja2_template to accept either a file path or raw text as input. The updated function first checks if the provided string corresponds to an existing file. If a file exists at that path, its content is used as the template; otherwise, the input string itself is treated as the template.
However, when the input is a long raw template string (exceeding file name length limits), attempting to validate the path via
path.exists()could trigger anOSError. To address this, this PR introduces a try-except block to bypass such errors, ensuring the function remains functional even for a long input.