Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement trait std::error::Error for Error #4

Closed
wants to merge 1 commit into from
Closed

Implement trait std::error::Error for Error #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ impl std::fmt::Display for Error {
}
}

impl std::error::Error for Error {
fn description(&self) -> &str {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::error::Error::description is soft-deprecated, impl Display is enough.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required for compability with failure. OK then, I'll fix this in my code by wrapping lxc::Error into custom type which directly implements failure::Fail.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the description function implementation was deprecated. Implementing Error is a good idea. You can reopen this PR and amend your commit to remove the unnecessary code.

"LXC error"
}
}

pub type Result<T> = std::result::Result<T, Error>;

/**
Expand Down