Implement trait std::error::Error for Error #4

johnlepikhin · 2019-11-08T18:09:23Z

No description provided.

sanpii · 2019-11-09T08:36:42Z

src/lib.rs

@@ -26,6 +26,12 @@ impl std::fmt::Display for Error {
    }
 }

+impl std::error::Error for Error {
+    fn description(&self) -> &str {


std::error::Error::description is soft-deprecated, impl Display is enough.

This is required for compability with failure. OK then, I'll fix this in my code by wrapping lxc::Error into custom type which directly implements failure::Fail.

This is just the description function implementation was deprecated. Implementing Error is a good idea. You can reopen this PR and amend your commit to remove the unnecessary code.

Implement trait std::error::Error for Error

f42d5b8

sanpii requested changes Nov 9, 2019

View reviewed changes

johnlepikhin closed this Nov 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement trait std::error::Error for Error #4

Implement trait std::error::Error for Error #4

johnlepikhin commented Nov 8, 2019

sanpii Nov 9, 2019

johnlepikhin Nov 12, 2019

sanpii Nov 13, 2019

Implement trait std::error::Error for Error #4

Implement trait std::error::Error for Error #4

Conversation

johnlepikhin commented Nov 8, 2019

sanpii Nov 9, 2019

Choose a reason for hiding this comment

johnlepikhin Nov 12, 2019

Choose a reason for hiding this comment

sanpii Nov 13, 2019

Choose a reason for hiding this comment