switch to n_vertices, n_edges and n_faces for graphs #40918
Conversation
|
I did not touch the method names in the graph backends. Should I change them and add aliases for consistency? |
|
Documentation preview for this PR (built with commit 57156ca; changes) is ready! 🎉 |
Yes, that would be better. Thanks. |
|
There are about 50 files in total that use |
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
LGTM.
changes in the codebase can be done in future PR if needed.
Thanks.
Thank you! Small request: could you (and @fchapoton, and whoever else might be interested) please make a decision. It would be easier for me to do it now (happily in a different PR) than in a few weeks. |
|
For the graph module (at least), yes you can do changes in the codebase as well. We have the aliases for compatibility. Thanks. |
sagemathgh-40918: switch to n_vertices, n_edges and n_faces for graphs This provides aliases `n_vertices`, `n_edges` and `n_faces`, and uses them throughout the docstring `EXAMPLES`. The old aliases `num_verts`,`num_edges` and `num_faces` are kept. Also, they are kept in the code base, to avoid touching too many files. URL: sagemath#40918 Reported by: Martin Rubey Reviewer(s): David Coudert
sagemathgh-40932: use n_vertices, n_edges and n_faces also in the codebase To achieve better consistency, we replace `num_verts`, `num_edges` and `num_faces` with `n_vertices`, `n_edges` and `n_faces` also in the codebase. `num_verts`, `num_edges` and `num_faces` remain aliases for backwards compatibility. dependencies: sagemath#40918 URL: sagemath#40932 Reported by: Martin Rubey Reviewer(s): David Coudert
sagemathgh-40932: use n_vertices, n_edges and n_faces also in the codebase To achieve better consistency, we replace `num_verts`, `num_edges` and `num_faces` with `n_vertices`, `n_edges` and `n_faces` also in the codebase. `num_verts`, `num_edges` and `num_faces` remain aliases for backwards compatibility. dependencies: sagemath#40918 URL: sagemath#40932 Reported by: Martin Rubey Reviewer(s): David Coudert
4 participants
This provides aliases
n_vertices,n_edgesandn_faces, and uses them throughout the docstringEXAMPLES.The old aliases
num_verts,num_edgesandnum_facesare kept. Also, they are kept in the code base, to avoid touching too many files.