use n_vertices, n_edges and n_faces also in the codebase #40932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_vertices respectively
mantepse
changed the title
Contributor
|
it seems that the branch has conflicts |
|
Documentation preview for this PR (built with commit edba108; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 5, 2025
sagemathgh-40932: use n_vertices, n_edges and n_faces also in the codebase To achieve better consistency, we replace `num_verts`, `num_edges` and `num_faces` with `n_vertices`, `n_edges` and `n_faces` also in the codebase. `num_verts`, `num_edges` and `num_faces` remain aliases for backwards compatibility. dependencies: sagemath#40918 URL: sagemath#40932 Reported by: Martin Rubey Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 10, 2025
sagemathgh-40939: n_nodes and number_of_nodes_xxx in tree related classes fix sagemath#40935 in tree related classes. cf sagemath#40932 Should `number_of_nodes` also be an alias, or perhaps instead of `n_nodes`? Should `n_nodes_to_the_right`, `n_nodes_at_depth` also be aliases? Does this pollute the namespace too much? URL: sagemath#40939 Reported by: Martin Rubey Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 11, 2025
sagemathgh-40939: n_nodes and number_of_nodes_xxx in tree related classes fix sagemath#40935 in tree related classes. cf sagemath#40932 Should `number_of_nodes` also be an alias, or perhaps instead of `n_nodes`? Should `n_nodes_to_the_right`, `n_nodes_at_depth` also be aliases? Does this pollute the namespace too much? URL: sagemath#40939 Reported by: Martin Rubey Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achieve better consistency, we replace
num_verts,num_edgesandnum_faceswithn_vertices,n_edgesandn_facesalso in the codebase.num_verts,num_edgesandnum_facesremain aliases for backwards compatibility.dependencies: #40918