Skip to content

replace gone in python3.14 FancyURL #40888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

replace gone in python3.14 FancyURL #40888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34a52c1
replace gone in python3.14 FancyURL
dimpase Sep 25, 2025
b197437
allow tar to be tar with its security flaws
dimpase Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions build/sage_bootstrap/download/transfer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
log = logging.getLogger()

from sage_bootstrap.stdio import flush
from sage_bootstrap.compat import urllib
import urllib
from urllib.request import build_opener, install_opener, urlretrieve


class ProgressBar(object):
Expand Down Expand Up @@ -120,16 +121,17 @@ def error_progress_bar(self):
self.progress_bar.error_stop()

def run(self):
opener = urllib.FancyURLopener()
opener = build_opener()
install_opener(opener)

opener.http_error_default = self.http_error_default
self.start_progress_bar()
try:
if self.progress:
filename, info = opener.retrieve(
self.url, self.destination, self.progress_bar)
urlretrieve(self.url, self.destination, reporthook=self.progress_bar)
else:
filename, info = opener.retrieve(
self.url, self.destination)
urlretrieve(self.url, self.destination)

except IOError as error:
self.error_progress_bar()
log.error(error)
Expand Down
2 changes: 1 addition & 1 deletion build/sage_bootstrap/uncompress/tar_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def extractall(self, path='.', members=None, **kwargs):
else name_to_member[m]
for m in members]
return super(SageBaseTarFile, self).extractall(path=path,
members=members,
members=members, filter='fully_trusted',
**kwargs)

def extractbytes(self, member):
Expand Down
Loading