-
-
Notifications
You must be signed in to change notification settings - Fork 673
replace gone in python3.14 FancyURL #40888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Downloading works, but uncompressing downloaded tarballs does not work on Python 3.14.
|
Documentation preview for this PR (built with commit b197437; changes) is ready! 🎉 |
See https://docs.python.org/3.14/library/tarfile.html#tarfile-extraction-filter Changed in version 3.14: The default filter is set to data. Previously, the default was equivalent to fully_trusted.
I think this should suffice for a positive review |
perhaps check with some old Python 3, e.g. 3.8 |
I do not have access to systems working with these versions. Is it a problem for a positive review? |
Well, I tested with Python 3.8 as a "system" Python. (Actually, using I think it's good enough, you can turn this to a positive review. PS. An additional, complete cleanup of these python2/3 old features can be done later. |
sagemathgh-40888: replace gone in python3.14 FancyURL FancyURL has been long deprecated, since Python 3.3. It's finally gone in 3.14, so we need this to move forward, e.g. on Fedora 43, as reported on [sage-support](https://groups.google.com/g/sage- support/c/12GaUYfAbD0/m/1RcOQypjAwAJ) This will fix sagemath#40886 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40888 Reported by: Dima Pasechnik Reviewer(s): Enrique Manuel Artal Bartolo
FancyURL has been long deprecated, since Python 3.3.
It's finally gone in 3.14, so we need this to move forward, e.g. on Fedora 43,
as reported on sage-support
This will fix #40886
📝 Checklist
⌛ Dependencies