Skip to content

some typing -> bool for is_* methods #40865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2025
Merged

some typing -> bool for is_* methods #40865

merged 3 commits into from
Sep 27, 2025

Conversation

fchapoton
Copy link
Contributor

just adding some simple -> bool annotations

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 21, 2025 •
edited
Loading

Documentation preview for this PR (built with commit c77e600; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

dcoudert
dcoudert reviewed Sep 22, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future PRs we will have to unify the different forms: Test whether, Return True if, Determine whether, Return whether, Test if, etc.

dcoudert
dcoudert approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fchapoton
Copy link
Contributor Author

merci !

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 24, 2025
08fd0fd 
sagemathgh-40865: some typing -> bool for is_* methods
    
just adding some simple `-> bool` annotations

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40865
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit f933e1b into sagemath:develop Sep 27, 2025
23 of 25 checks passed
@fchapoton fchapoton deleted the typing_for_is branch September 29, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @dcoudert @vbraun