Skip to content

Filter FFCPs by to-announce label on prioritization#762

Merged
Mark-Simulacrum merged 1 commit intorust-lang:masterfrom
spastorino:fix-prioritization-ffcps
Aug 13, 2020
Merged

Filter FFCPs by to-announce label on prioritization#762
Mark-Simulacrum merged 1 commit intorust-lang:masterfrom
spastorino:fix-prioritization-ffcps

Conversation

@spastorino
Copy link
Copy Markdown
Member

This PR goes with rust-lang/rfcbot-rs#289. Even with that one not yet merged it won't hurt our process to merge this PR.

r? @Mark-Simulacrum

cc @rust-lang/wg-prioritization

@Mark-Simulacrum
Copy link
Copy Markdown
Member

Hm, I don't quite follow -- won't this exclude all FCPs from the list? Happy to merge anyway, though.

@spastorino spastorino force-pushed the fix-prioritization-ffcps branch from 9e28bfc to dfe399a Compare August 13, 2020 13:36
@spastorino
Copy link
Copy Markdown
Member Author

@Mark-Simulacrum the idea there was to list only finished FCPs that are in disposition merge state. It's just that the queries that we were using didn't make sense due to the lack of rust-lang/rfcbot-rs#289 and I was manually adjusting the FCPs.

@Mark-Simulacrum
Copy link
Copy Markdown
Member

Ah, okay, if you're manually adjusting that makes sense then.

@Mark-Simulacrum Mark-Simulacrum merged commit f4249ee into rust-lang:master Aug 13, 2020
@spastorino
Copy link
Copy Markdown
Member Author

@Mark-Simulacrum right, the idea with these two PRs is to automate it and stop manual processing things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants