Skip to content

Add to-announce to FCPs once they are finished #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spastorino opened this issue Jul 15, 2020 · 6 comments
Closed

Add to-announce to FCPs once they are finished #9

spastorino opened this issue Jul 15, 2020 · 6 comments

Comments

@spastorino
Copy link
Member

We would need to automatically add a to-announce label to finished FCPs on rust repo, so our prioritization cli can pick them up to make the announcements of them. Otherwise we would get this full list of finished FCPs.

@LeSeulArtichaut
Copy link

There is no to-announce label in the rust-lang/rust repo. Once we’ve created it, we should be able to use triagebot’s autolabeling system to add it whenever the finished-final-comment-period label is added.

@spastorino
Copy link
Member Author

@LeSeulArtichaut yeah I know, adding the label would be step 1 :). Going to ask Niko and/or Felix about this.

@spastorino
Copy link
Member Author

@LeSeulArtichaut I've talked to Niko, we agreed on this and just created the label.

@LeSeulArtichaut
Copy link

@spastorino Should we add it on all finished FCPs or only on T-compiler ones?

@spastorino
Copy link
Member Author

If they are properly tagged I'd say only T-compiler ones.

@spastorino
Copy link
Member Author

I've implemented this in triagebot and rfcbot.

rust-lang/triagebot#762
rust-lang/rfcbot-rs#289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants