Update the minimum external LLVM to 19 #139275
Merged
+222
−1,911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Some changes occurred in coverage tests. cc @Zalathar This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
This comment has been minimized.
This comment has been minimized.
nikic
reviewed
Apr 2, 2025
| @@ -270,20 +269,9 @@ pub(crate) fn to_llvm_features<'a>(sess: &Session, s: &'a str) -> Option<LLVMFea | |||
| ("aarch64", "fhm") => Some(LLVMFeature::new("fp16fml")), | |||
| ("aarch64", "fp16") => Some(LLVMFeature::new("fullfp16")), | |||
| // Filter out features that are not supported by the current LLVM version | |||
| ("aarch64", "fpmr") if get_version().0 != 18 => None, | |||
| ("aarch64", "fpmr") => None, // only existed in 18 | |||
There was a problem hiding this comment.
Why do we need to retain this feature?
There was a problem hiding this comment.
I'm not sure in which context it would have been specified and needed to be filtered out before. e.g. was that only from unstable #[target_feature] or -Ctarget-feature?
There was a problem hiding this comment.
@mrkajetanp Do we need to keep this target feature around?
It looks like there is some runtime detection support for it: https://github.com/rust-lang/stdarch/blob/65712f37fb4d8f275e5eb7bd7b0057fdd68a91aa/crates/std_detect/src/detect/arch/aarch64.rs#L162-L164
I'm not super clear on how/why we're supporting target features that LLVM doesn't.
There was a problem hiding this comment.
The relevant discussion was here: #128192
The approach we settled on was this:
We switch it on by default through target specs on LLVM 18, it's already switched on on LLVM 19+ and it doesn't exist on older LLVM versions. But we do keep the detection in std_detect.
So, if we no longer support LLVM 18 then it should not be necessary.
There was a problem hiding this comment.
We'll need to remove it from stdarch first though, right? If so, then I suggest:
- Merge this PR with the
=> Nonefilter. - Remove "fpmr" from
stdarch. - Update
stdarchand drop that line in a followup.
There was a problem hiding this comment.
In that case, it would be nice to add an appropriate FIXME comment to this PR that mentions the stdarch plan.
There was a problem hiding this comment.
It might be desirable to keep it in stdarch for runtime detection. You no longer need to enable it for LLVM to use it, but you may still want to check whether the machine your code runs on actually supports it.
|
Okay, I think we can figure out the details of the fpmr handling as a followup... @bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 4, 2025
Update the minimum external LLVM to 19 With this change, we'll have stable support for LLVM 19 and 20. For reference, the previous increase to LLVM 18 was rust-lang#130487. cc `@rust-lang/wg-llvm` r? nikic
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 4, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#138546 (Add integer to string formatting tests) - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names) - rust-lang#139028 (Make target maintainers more easily pingable) - rust-lang#139274 (Rustdoc: typecheck settings.js) - rust-lang#139275 (Update the minimum external LLVM to 19) - rust-lang#139328 (Fix 2024 edition doctest panic output) Failed merges: - rust-lang#138947 (Refactor Apple version handling in the compiler) r? `@ghost` `@rustbot` modify labels: rollup
|
@bors r- rollup=iffy |
bors
added
S-waiting-on-author
|
That just needed a line-number @bors r=nikic |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2025
Update the minimum external LLVM to 19 With this change, we'll have stable support for LLVM 19 and 20. For reference, the previous increase to LLVM 18 was rust-lang#130487. cc `@rust-lang/wg-llvm` r? nikic
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-review
cuviper
commented
Apr 5, 2025
|
@bors r=nikic |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5e17a2a (parent) -> c211076 (this PR) Test differencesShow 56 test diffsStage 1
Stage 2
Job group index
Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Apr 6, 2025
|
Finished benchmarking commit (c211076): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 776.183s -> 775.586s (-0.08%) |
cuviper
added
the
relnotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we'll have stable support for LLVM 19 and 20.
For reference, the previous increase to LLVM 18 was #130487.
cc @rust-lang/wg-llvm
r? nikic