Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LLVM 18 inline ASM span fallback #139431

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Remove LLVM 18 inline ASM span fallback #139431

merged 1 commit into from
Apr 7, 2025

Conversation

beetrees
Copy link
Contributor

@beetrees beetrees commented Apr 6, 2025

The minimum supported LLVM version is now 19, so this fallback is no longer required.

@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2025

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 6, 2025
@cuviper
Copy link
Member

cuviper commented Apr 6, 2025

Just for reference, #139275 raised that minimum.

jieyouxu
jieyouxu approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

jieyouxu commented Apr 7, 2025

r? jieyouxu
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 7, 2025

📌 Commit 3aac9a3 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2025
@Kobzol Kobzol mentioned this pull request Apr 7, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2025
@bors
Auto merge of rust-lang#139473 - Kobzol:rollup-ycksn9b, r=Kobzol
8fb32ab 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#138314 (fix usage of `autodiff` macro with inner functions)
 - rust-lang#139426 (Make the UnifyKey and UnifyValue imports non-nightly)
 - rust-lang#139431 (Remove LLVM 18 inline ASM span fallback)
 - rust-lang#139456 (style guide: add let-chain rules)
 - rust-lang#139467 (More trivial tweaks)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5012354 into rust-lang:master Apr 7, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 7, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2025
@rust-timer
Unrolled build for rust-lang#139431
3b606b3 
Rollup merge of rust-lang#139431 - beetrees:no-llvm-18, r=jieyouxu

Remove LLVM 18 inline ASM span fallback

The minimum supported LLVM version is now 19, so this fallback is no longer required.
@beetrees beetrees deleted the no-llvm-18 branch April 8, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
6 participants
@beetrees @rustbot @cuviper @jieyouxu @bors @oli-obk