Add diesel to the benchmark suite #8030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds diesel to the continuosly run benchmark suite. Diesel heavily relies internally on macro generated code. Additionally there are lots of complicated trait releations used as part of their API. Therefore this benchmark will be quite sensitive to: * Performance related changes in the macro expanding code * Performance related changes while resolving trait bounds CC rust-lang#7950
|
changelog internal add |
|
Looks like this should take about 5-6 minutes on CI. It might be pretty painful, but let's tentatively merge it. I checked bors r+ |
matklad
reviewed
Mar 15, 2021
| @@ -26,7 +26,7 @@ impl flags::Metrics { | |||
| } | |||
| { | |||
| let _d = pushd("./target/rustc-perf")?; | |||
| cmd!("git reset --hard 1d9288b0da7febf2599917da1b57dc241a1af033").run()?; | |||
| cmd!("git reset --hard c52ee623e231e7690a93be88d943016968c1036b").run()?; | |||
There was a problem hiding this comment.
We should add this hash to JSON we publish to the metrics repo, so that it's easy to see when we update the test suite.
|
Great, this broke the metrics dashboard :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds diesel to the continuosly run benchmark suite. Diesel
heavily relies internally on macro generated code. Additionally there
are lots of complicated trait releations used as part of their API.
Therefore this benchmark will be quite sensitive to:
CC #7950
cc @lnicola