Skip to content

Add benchmark suite hash to the metrics JSON #8031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lnicola opened this issue Mar 15, 2021 · 3 comments
Closed

Add benchmark suite hash to the metrics JSON #8031

lnicola opened this issue Mar 15, 2021 · 3 comments
Labels
good first issue S-actionable Someone could pick this issue up and work on it right now

Comments

@lnicola
Copy link
Member

lnicola commented Mar 15, 2021

We should add this hash to JSON we publish to the metrics repo, so that it's easy to see when we update the test suite.

Originally posted by @matklad in #8030 (comment)
@lnicola lnicola added good first issue S-actionable Someone could pick this issue up and work on it right now labels Mar 15, 2021
@d2weber d2weber mentioned this issue Mar 15, 2021
Merged
@d2weber
Copy link

d2weber commented Mar 16, 2021

I took the opportunity to start with this issue and submitted a pull request.

@lnicola
Copy link
Member Author

lnicola commented Mar 16, 2021

Yes, sorry for the delay.

bors bot added a commit that referenced this issue Mar 16, 2021
@bors @d2weber
Merge #8042
9caeef9 
8042: Add perf_revision to benchmark results r=lnicola a=d2weber

I gave it a try to add the hash as described in #8031 
Feel free to tell me if there is something I could improve.

Co-authored-by: Douglas Weber <[email protected]>
@lnicola lnicola closed this as completed Mar 16, 2021
@d2weber
Copy link

d2weber commented Mar 16, 2021

Yes, sorry for the delay.

No worries, thanks for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lnicola @d2weber