Fix fastboot check in nginx erb template #2063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In production we're currently returning a 502 Bad Gateway for `/policies`. I intend to merge this and deploy to production shortly. This bug was introduced in rust-lang#1907. The bad check always evaluated to true. An explicit check for an empty string is added as well. I've tested this locally with `erb` and different values and the generated configuration is now working correctly.
|
@bors r+ |
|
📌 Commit f6b8b59 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 25, 2019
Fix fastboot check in nginx erb template In production we're currently returning a 502 Bad Gateway for `/policies`. I intend to merge this and deploy to production shortly. This bug was introduced in #1907. The bad check always evaluated to true. An explicit check for an empty string is added as well. I've tested this locally with `erb` and different values and the generated configuration is now working correctly. r? @jtgeibel
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production we're currently returning a 502 Bad Gateway for
/policies. I intend to merge this and deploy to production shortly.This bug was introduced in #1907. The bad check always evaluated to
true. An explicit check for an empty string is added as well. I've
tested this locally with
erband different values and the generatedconfiguration is now working correctly.
r? @jtgeibel