Fix fastboot check in nginx erb template

jtgeibel · jtgeibel · commit f6b8b59e9a27 · 2019-12-24T20:46:08.000-05:00
In production we're currently returning a 502 Bad Gateway for `/policies`. I intend to merge this and deploy to production shortly. This bug was introduced in #1907. The bad check always evaluated to true. An explicit check for an empty string is added as well. I've tested this locally with `erb` and different values and the generated configuration is now working correctly.
diff --git a/config/nginx.conf.erb b/config/nginx.conf.erb
@@ -141,7 +141,7 @@ http {
 			location / {
 				proxy_pass http://localhost:9000;
 			}
-		<% elsif ['USE_FASTBOOT'] %>
+		<% elsif ENV['USE_FASTBOOT'] && !ENV['USE_FASTBOOT'].empty? %>
 			# Fastboot is enabled only for allowed paths
 
 			location = /policies {

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ http {`
`141`	`141`	`location / {`
`142`	`142`	`proxy_pass http://localhost:9000;`
`143`	`143`	`}`
`144`		`- <% elsif ['USE_FASTBOOT'] %>`
	`144`	`+ <% elsif ENV['USE_FASTBOOT'] && !ENV['USE_FASTBOOT'].empty? %>`
`145`	`145`	`# Fastboot is enabled only for allowed paths`
`146`	`146`
`147`	`147`	`location = /policies {`