fix: update resolve_all_features() to filter pkg deps
#16221
+26
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Before,
resolve_all_features()isn't filtering dependencies, as it uses the set returned byResolve::deps()directly which is mostly unfiltered. This PR fixes it by having the set goes throughPackageSet::filter_deps()'s filter.Note that this patch changed
resolve_all_features()'s function signature as well as madePackageSet::filter_deps()public.Close #15399
How to test and review this PR?
As described in #15399,
cargo test --frozenshould not panic (doesn't try to download unneeded deps) when does the following:More discussion on Zulip chat.