Skip to content

Add language tags for hi-rustin's name so it renders correctly #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

Manishearth
Copy link
Member

包 renders differently in Chinese and Japanese, ( vs ), ensuring that the correct rendering is used.

Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL 👍

Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting!

How to reproduce the rendering difference? It seems correct on my machine even without this patch.

@bjorn3
Copy link
Member

bjorn3 commented Mar 14, 2024

As I understand it, it will render incorrectly if your browser is configured for Japanese.

@weihanglo
Copy link
Member

Understood. Thanks!

I always have zh-hants in my preferred language list so TIL :)

@Manishearth
Copy link
Member Author

As I understand it, it will render incorrectly if your browser is configured for Japanese.

or if your browser is not configured at all and it defaults to Japanese

@Manishearth Manishearth merged commit f5aeec9 into master Mar 14, 2024
3 checks passed
@Manishearth Manishearth deleted the Manishearth-patch-1 branch March 14, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants