Remove deprecated create_tunnel tests from smoketests#759
Merged
Conversation
- Removed test_create_tunnel_deprecated from sync test suite - Removed test_create_tunnel_deprecated from async test suite - Tests for enable_tunnel endpoint remain in place as the recommended approach Co-authored-by: albert <[email protected]>
james-rl
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the deprecated
test_create_tunnel_deprecatedtests from the smoketest suite, as they test the deprecated/create_tunnelendpoint which should no longer be used.Changes
test_create_tunnel_deprecatedfrom sync devbox smoketests (tests/smoketests/sdk/test_devbox.py)test_create_tunnel_deprecatedfrom async devbox smoketests (tests/smoketests/sdk/test_async_devbox.py)Notes
test_enable_tunneltests remain in place and provide coverage for the recommended/enable_tunnelendpointcreate_tunnelendpoint was noted in the test comments to be superseded byenable_tunnelSlack Thread